codope commented on a change in pull request #4758:
URL: https://github.com/apache/hudi/pull/4758#discussion_r800537612
##########
File path:
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -573,6 +575,7 @@ object HoodieSparkSqlWriter {
hiveSyncConfig.syncMode = hoodieConfig.getString(HIVE_SYNC_MODE)
hiveSyncConfig.serdeProperties =
hoodieConfig.getString(HIVE_TABLE_SERDE_PROPERTIES)
hiveSyncConfig.tableProperties =
hoodieConfig.getString(HIVE_TABLE_PROPERTIES)
+ hiveSyncConfig.sparkVersion = SPARK_VERSION
Review comment:
How about also setting this for hive sync triggered through
deltastreamer as well? `DeltaSync` uses `DataSourceUtils#buildHiveSyncConfig`
to create hive sync configs.
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -302,6 +303,9 @@ private boolean syncSchema(String tableName, boolean
tableExists, boolean useRea
Map<String, String> sparkProperties = new HashMap<>();
sparkProperties.put("spark.sql.sources.provider", "hudi");
+ if (!StringUtils.isNullOrEmpty(cfg.sparkVersion)) {
+ sparkProperties.put("spark.sql.create.version", cfg.sparkVersion);
Review comment:
Is it just for visibility/debugging purpose, or does hive use this
config in some way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
