nsivabalan commented on a change in pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#discussion_r800576733
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java
##########
@@ -88,15 +89,15 @@ private static String getStrictlyLowerTimestamp(String
timestamp) {
}
});
- if (!beginInstantTime.equals(DEFAULT_BEGIN_TIMESTAMP)) {
+ if (missingCheckpointStrategy == MissingCheckpointStrategy.READ_LATEST) {
Review comment:
its not required. if begin timestamp is empty we check the missing
checkpoint strategy to determine the right values for begin timestamp and end
timestamp.
and later we just rely on the strategy to determine whether we want to make
incr query or snapshot query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
