nsivabalan commented on a change in pull request #4744:
URL: https://github.com/apache/hudi/pull/4744#discussion_r800580550
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -376,6 +377,29 @@ public void refreshTimeline() throws IOException {
}
LOG.info("Checkpoint to resume from : " + resumeCheckpointStr);
+ int maxRetryCount = cfg.retryOnSourceFailures ? cfg.maxRetryCount : 1;
+ int curRetryCount = 0;
+ Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> sourceDataToSync
= null;
+ while (curRetryCount++ < maxRetryCount && sourceDataToSync == null) {
Review comment:
yes, I am not adding explicit break inside the while loop.
for eg, lets say retries are enabled, and we go into while loop. max retry
count is 10. after 2 retries, if source connection succeeds, we have to get out
of while loop w/o going for next round.
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
##########
@@ -376,6 +377,29 @@ public void refreshTimeline() throws IOException {
}
LOG.info("Checkpoint to resume from : " + resumeCheckpointStr);
+ int maxRetryCount = cfg.retryOnSourceFailures ? cfg.maxRetryCount : 1;
+ int curRetryCount = 0;
+ Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> sourceDataToSync
= null;
+ while (curRetryCount++ < maxRetryCount && sourceDataToSync == null) {
Review comment:
yes, I am not adding explicit break inside the while loop and hence.
for eg, lets say retries are enabled, and we go into while loop. max retry
count is 10. after 2 retries, if source connection succeeds, we have to get out
of while loop w/o going for next round.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
