alexeykudinkin commented on a change in pull request #4559:
URL: https://github.com/apache/hudi/pull/4559#discussion_r800905487
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileInputFormatBase.java
##########
@@ -172,35 +198,25 @@ private static FileStatus
getFileStatusUnchecked(HoodieBaseFile baseFile) {
return HoodieInputFormatUtils.filterIncrementalFileStatus(jobContext,
tableMetaClient, timeline.get(), fileStatuses, commitsToCheck.get());
}
- protected abstract boolean includeLogFilesForSnapshotView();
+ @Override
+ protected FileSplit makeSplit(Path file, long start, long length,
+ String[] hosts, String[] inMemoryHosts) {
+ FileSplit split = new FileSplit(file, start, length, hosts, inMemoryHosts);
+ if (file instanceof PathWithBootstrapFileStatus) {
Review comment:
@yihua GH comments are weird, when i was responding to @nsivabalan there
were no comments of yours, and then it sandwiched your comment in b/w of those.
> My understanding is that these methods are moved from
HoodieParquetInputFormat. @alexeykudinkin is the logic parquet agnostic and
going to be reused by other file formats like HFile? I think if that's not the
case, better to keep them in HoodieParquetInputFormat, since this base class is
going to be general for different formats.
Your understanding is correct, all of this logic is file-format agnostic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
