pratyakshsharma commented on a change in pull request #4385:
URL: https://github.com/apache/hudi/pull/4385#discussion_r801346627
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##########
@@ -143,6 +143,10 @@ public static String makeNewCommitTime(int sequence) {
return String.format("%09d", sequence);
}
+ public static String makeNewCommitTimeInHudiFormat(int sequence) {
Review comment:
> can we get makeNewCommitTime work as-is?
`makeNewCommitTime` actually creates the instants with a size of 9 digits
while the actual instants are created with a size of 14 digits. I was facing
issues when comparing the timestamps in test cases due to the difference of
sizes, hence had to introduce a new method. I wanted to understand why did we
originally have `makeNewCommitTime` create instants of size 9 digits?
@vinothchandar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
