xushiyan commented on a change in pull request #4752:
URL: https://github.com/apache/hudi/pull/4752#discussion_r801636606
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestKafkaOffsetGen.java
##########
@@ -164,10 +163,17 @@ public void testGetNextOffsetRangesFromGroup() {
// committed offsets are not present for the consumer group
kafkaOffsetGen = new KafkaOffsetGen(getConsumerConfigs("group", "string"));
nextOffsetRanges = kafkaOffsetGen.getNextOffsetRanges(Option.empty(), 300,
metrics);
- assertEquals(500, nextOffsetRanges[0].fromOffset());
- assertEquals(500, nextOffsetRanges[0].untilOffset());
- assertEquals(500, nextOffsetRanges[1].fromOffset());
- assertEquals(500, nextOffsetRanges[1].untilOffset());
+ if (494 == nextOffsetRanges[0].fromOffset()) {
Review comment:
can you help explain this condition check please?
##########
File path: pom.xml
##########
@@ -93,7 +93,7 @@
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
<fasterxml.spark3.version>2.10.0</fasterxml.spark3.version>
- <kafka.version>2.4.1</kafka.version>
+ <kafka.version>2.8.0</kafka.version>
Review comment:
do we have to upgrade this? previously spark 3 profile uses 2.4.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
