stayrascal commented on pull request #4724: URL: https://github.com/apache/hudi/pull/4724#issuecomment-1032725182
> Thanks for the contribution ~ I kind of think we better do this after id-based schema evolution is supported, only after that, we have more light-wright solution to support per-record schema. > > Generally, take schema with record seems not a good solution. Yeah, agree with taking schema with record is not a good solution, it couple the byte data with schema and hard to evolute schema later, but it seems that we cannot merge two `Payload` without schema. I also tired if we can pass the `schema` to `#preCombine` method, just similar with `#combineAndGetUpdateValue`. But we only can get the schema info from flink configuration, the `FlinkWriteHelper` doesn't(and should not) support flink configuration to support retrieve schema from configuration, so I have to inject schema via constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
