yihua commented on a change in pull request #4669:
URL: https://github.com/apache/hudi/pull/4669#discussion_r802100592
##########
File path: hudi-common/pom.xml
##########
@@ -38,18 +38,6 @@
<pluginManagement>
<plugins>
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <version>${scala-maven-plugin.version}</version>
- <configuration>
- <args>
- <arg>-nobootcp</arg>
- <arg>-target:jvm-1.8</arg>
- </args>
- <checkMultipleScalaVersions>false</checkMultipleScalaVersions>
- </configuration>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Review comment:
Should the `<pluginManagement>` be removed altogether? I see
maven-compiler-plugin is added before mainly for compiling both Java and Scala
code.
##########
File path: hudi-common/pom.xml
##########
@@ -58,27 +46,6 @@
</pluginManagement>
<plugins>
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <executions>
- <execution>
- <id>scala-compile-first</id>
- <phase>process-resources</phase>
- <goals>
- <goal>add-source</goal>
- <goal>compile</goal>
- </goals>
- </execution>
- <execution>
- <id>scala-test-compile</id>
- <phase>process-test-resources</phase>
- <goals>
- <goal>testCompile</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Review comment:
same here for this plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
