Wenning Ding created HUDI-3395:
----------------------------------

             Summary: Allow pass rollbackUsingMarkers to Hudi CLI rollback 
command
                 Key: HUDI-3395
                 URL: https://issues.apache.org/jira/browse/HUDI-3395
             Project: Apache Hudi
          Issue Type: Bug
            Reporter: Wenning Ding


In a recent OSS 
[change|https://github.com/apache/hudi/commit/ce7d2333078e4e1f16de1bce6d448c5eef1e4111],
 {{hoodie.rollback.using.markers}} is enabled by default. However, if you are 
trying rolling back a completed instance, Hudi would throw this exception:

 

{{Caused by: java.lang.IllegalArgumentException: Cannot use marker based 
rollback strategy on completed instant:[20211228041514616__commit__COMPLETED]at 
org.apache.hudi.common.util.ValidationUtils.checkArgument(ValidationUtils.java:40)}}

The problem in our integration test {{{}testHudiCliRollback{}}}, it tries 
rolling back a complete instance. But right now, through Hudi CLI, the {{commit 
rollback}} command does not provide customers anyway to disable 
{{hoodie.rollback.using.markers}} which means customers can never use {{commit 
rollback}} command to rollback a completed commit. So in this CR, I added a 
parameter called {{usingMarkers}} so that customers can disable this feature,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to