nsivabalan commented on a change in pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#discussion_r802266410



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/util/queue/BoundedInMemoryQueue.java
##########
@@ -204,6 +204,7 @@ private boolean expectMoreRecords() {
    * singleton iterator for this queue.
    */
   private Option<O> readNextRecord() {
+    checkIfInterrupted();

Review comment:
       do we need to check if interrupted for every record processing? will 
there be any negative impact on perf due to this. This is all in memory, and 
should not be an issue. but wanted to see if this is absolutely necessary. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to