liujinhui1994 commented on pull request #3614: URL: https://github.com/apache/hudi/pull/3614#issuecomment-1033473571
> @liujinhui1994根据我们的讨论，这里有几点 > > * `hoodie.parquet.encryption.keys`可以用作开关。默认不设置。如果未设置，则禁用加密功能。用户提供的任何镶木地板设置都将被忽略 > * 如果用户启用了加密但`hoodie.table.base.file.format`不是镶木地板，则应该有一些警告以向用户突出显示 > * 将其标记为实验性功能会很好。您可以在配置的文档和相关的 java 类的文档中用更多的细节（比如为什么是实验性的）来澄清这一点。发行说明也将突出显示它。 > @liujinhui1994 per our discussions, some points here > > * `hoodie.parquet.encryption.keys` can be used as the switch. default to not set. if not set, then encryption feature is disabled. any parquet settings users provide will be ignored > * If users enable encryption but `hoodie.table.base.file.format` is not parquet, there should be some warning to highlight it to the users > * it'll be good to mark this as experimental feature. you can clarify this with more details (like why experimental) in the config's docs and related java classes' docs. Release notes will also highlight it. ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
