xushiyan commented on a change in pull request #4752:
URL: https://github.com/apache/hudi/pull/4752#discussion_r802396594
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/testutils/UtilitiesTestBase.java
##########
@@ -410,6 +411,16 @@ public static String toJsonString(HoodieRecord hr) {
return
records.stream().map(Helpers::toJsonString).toArray(String[]::new);
}
+ public static Tuple2<String, String>[]
jsonifyRecordsByPartitions(List<HoodieRecord> records, int partitions) {
Review comment:
java class `org.apache.hudi.common.util.collection.Pair` is preferred
here over Tuple2
##########
File path:
hudi-utilities/src/test/java/org/apache/hudi/utilities/testutils/UtilitiesTestBase.java
##########
@@ -410,6 +411,16 @@ public static String toJsonString(HoodieRecord hr) {
return
records.stream().map(Helpers::toJsonString).toArray(String[]::new);
}
+ public static Tuple2<String, String>[]
jsonifyRecordsByPartitions(List<HoodieRecord> records, int partitions) {
+ Tuple2<String, String>[] data = new Tuple2[records.size()];
+ for (int i = 0; i < records.size(); i++) {
+ int key = i % partitions;
Review comment:
shouldn't it be better with
org.apache.hudi.common.model.HoodieKey#recordKey from each HoodieRecord ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
