n3nash commented on a change in pull request #1287: [HUDI-566] Added new test
cases for class HoodieTimeline, HoodieDefaultTimeline and HoodieActiveTimeline.
URL: https://github.com/apache/incubator-hudi/pull/1287#discussion_r372560120
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/table/string/TestHoodieActiveTimeline.java
##########
@@ -164,4 +173,242 @@ public void testTimelineOperations() {
assertFalse("", activeCommitTimeline.isBeforeTimelineStarts("02"));
assertTrue("", activeCommitTimeline.isBeforeTimelineStarts("00"));
}
+
+ @Test
+ public void testTimelineGetOperations() {
+ Vector<HoodieInstant> allInstants = getAllInstants();
Review comment:
What is the need to use a Vector here ? Does list not suffice ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
