nsivabalan commented on pull request #4619: URL: https://github.com/apache/hudi/pull/4619#issuecomment-1035865062
@YannByron : we also need to make a minor fix. When preserve commit metadata is enabled, we need to retain every meta field except filename. File name has to be overriden. guess I missed it when I added preserve commit metadata for compaction. Fix should go in [here](https://github.com/apache/hudi/blob/ba4e732ba75e12a02d07c09f2662678bdcafbdc2/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java#L297). You can check out the [fix](https://github.com/apache/hudi/blob/ba4e732ba75e12a02d07c09f2662678bdcafbdc2/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java#L144) we did for clustering for clustering preserve commit metadata. If you are occupied, let me know. I can push changes or put up a new patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
