xushiyan commented on a change in pull request #4777:
URL: https://github.com/apache/hudi/pull/4777#discussion_r806159392
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
##########
@@ -1142,7 +1152,13 @@ protected boolean scheduleCleaningAtInstant(String
instantTime, Option<Map<Strin
private Option<String> scheduleTableServiceInternal(String instantTime,
Option<Map<String, String>> extraMetadata,
TableServiceType
tableServiceType) {
+ if (!tableServicesEnabled(config)) {
+ return Option.empty();
+ }
switch (tableServiceType) {
+ case ARCHIVE:
+ LOG.info("Scheduling archiving is not supported. Skipping.");
Review comment:
@nsivabalan it's because `org.apache.hudi.common.model.TableServiceType`
was updated to include ARCHIVE, so the switch should enumerate the list for
completeness.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService
implements RunsTableService {
Review comment:
@nsivabalan i don't think we can drop `HoodieAsyncService` since the
async services for clean, archive, compact and cluster all inherit from
`HoodieAsyncService`. The `HoodieAsyncTableService` is to hold the common logic
like this switch. Besides, when there is `HoodieAsyncService`, then it's a
natural pattern to extend from it to make `HoodieAsyncTableService`. The
opposite would look odd: why wouldn't `HoodieAsyncTableService` extend
`HoodieAsyncService`
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService
implements RunsTableService {
+
+ protected HoodieWriteConfig writeConfig;
+
+ protected HoodieAsyncTableService() {
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig) {
+ this.writeConfig = writeConfig;
+ }
+
+ protected HoodieAsyncTableService(HoodieWriteConfig writeConfig, boolean
runInDaemonMode) {
+ super(runInDaemonMode);
+ this.writeConfig = writeConfig;
+ }
+
+ @Override
+ public void start(Function<Boolean, Boolean> onShutdownCallback) {
+ if (!tableServicesEnabled(writeConfig)) {
Review comment:
the main idea is: we can't prevent an async service to be instantiated
but we can prevent them from running by checking this in `start()`. It'd be
some code smell if we always check configs before creating an async service; we
better encapsulate the checking inside the services, hence this patch's
approach. Since the start() will never create a future to run async, shutdown()
or waitForShutdown() should just exit no-op. From the existing codebase, i see
`shutdown()` null-check `executor` but `waitForShutdown()` does not null-check
`future`. So I should add a null-check there as well.
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/HoodieAsyncTableService.java
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.async;
+
+import org.apache.hudi.client.RunsTableService;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import java.util.function.Function;
+
+public abstract class HoodieAsyncTableService extends HoodieAsyncService
implements RunsTableService {
Review comment:
@nsivabalan just recalled that `BaseHoodieWriteClient implements
RunsTableService` as it needs to guard other sync APIs, so we'd need both
`HoodieAsyncTableService` and `RunsTableService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
