yihua commented on a change in pull request #4824:
URL: https://github.com/apache/hudi/pull/4824#discussion_r808564878
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -659,13 +659,20 @@ public DeltaSync getDeltaSync() {
asyncCompactService.get().enqueuePendingAsyncServiceInstant(new
HoodieInstant(State.REQUESTED,
HoodieTimeline.COMPACTION_ACTION,
scheduledCompactionInstantAndRDD.get().getLeft().get()));
asyncCompactService.get().waitTillPendingAsyncServiceInstantsReducesTo(cfg.maxPendingCompactions);
+ if (asyncCompactService.get().hasError()) {
+ throw new HoodieException("Async compaction failed.
Shutting down Delta Sync...");
+ }
}
if (clusteringConfig.isAsyncClusteringEnabled()) {
Option<String> clusteringInstant =
deltaSync.getClusteringInstantOpt();
if (clusteringInstant.isPresent()) {
LOG.info("Scheduled async clustering for instant: " +
clusteringInstant.get());
asyncClusteringService.get().enqueuePendingAsyncServiceInstant(new
HoodieInstant(State.REQUESTED, HoodieTimeline.REPLACE_COMMIT_ACTION,
clusteringInstant.get()));
asyncClusteringService.get().waitTillPendingAsyncServiceInstantsReducesTo(cfg.maxPendingClustering);
+ if (asyncClusteringService.get().hasError()) {
+ error = true;
Review comment:
And yes, L662 should also set `error` to true. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
