alexeykudinkin opened a new pull request #4866:
URL: https://github.com/apache/hudi/pull/4866


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before 
opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Refactoring HoodieTestDataGenerator to provide for reproducible Builds: 
currently, `HoodieTestDataGenerator` relies on static state which make its 
state shared across all of the tests making data generation dependent on the 
order of execution.
   
   Instead we should properly abstract `HoodieTestDataGenerator` to hold all of 
the state w/in individual instances so that individual Tests can:
   
   1. Create they own isolated instance (which won't be affected by other Tests)
   2. Pass "seed" value to DataGenerator to init its PRNG w/ it, so that it 
always produces the same (pseudo-)random sequence (for a given seed)
   3. Be certain that all of the data produced by DataGenerator will be 100% 
reproducible w/ the same seed (meaning that all of the DataGenerator operations 
w/in it only rely on such internal PRNG and don't rely on any external sources, 
such as `UUID.randomUUID()`, `System.currentTimeMillis()`, etc)
   
   
   ## Brief change log
   
   See above
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to