prashantwason commented on a change in pull request #1298: [HUDI-587] Fixed 
generation of jacoco coverage reports.
URL: https://github.com/apache/incubator-hudi/pull/1298#discussion_r374913677
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -113,6 +113,7 @@
     <spark.bundle.hive.shade.prefix></spark.bundle.hive.shade.prefix>
     <utilities.bundle.hive.scope>provided</utilities.bundle.hive.scope>
     <utilities.bundle.hive.shade.prefix></utilities.bundle.hive.shade.prefix>
+    <argLine>-Xmx1024m -XX:MaxPermSize=256m</argLine>
 
 Review comment:
   I did not add this line. It was already part of the maven-surefire plugin's 
argLine.  I just moved the definition to a property so that jacoco plugin can 
add its own java-agent config to it and the unit tests can execute with jacococ 
agent enabled. 
   
   This was added in the following commit 3 months ago:
   https://github.com/apache/incubator-hudi/pull/979
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to