XuQianJin-Stars commented on a change in pull request #4535:
URL: https://github.com/apache/hudi/pull/4535#discussion_r811800454
##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/Table.java
##########
@@ -118,14 +118,12 @@ public Table flip() {
* @return
*/
private List<List<Comparable>> orderRows() {
- return orderingFieldNameOptional.map(orderingColumnName -> {
- return rawRows.stream().sorted((row1, row2) -> {
- Comparable fieldForRow1 =
row1.get(rowHeader.indexOf(orderingColumnName));
- Comparable fieldForRow2 =
row2.get(rowHeader.indexOf(orderingColumnName));
- int cmpRawResult = fieldForRow1.compareTo(fieldForRow2);
- return isDescendingOptional.map(isDescending -> isDescending ? -1 *
cmpRawResult : cmpRawResult).orElse(cmpRawResult);
- }).collect(Collectors.toList());
- }).orElse(rawRows);
+ return orderingFieldNameOptional.map(orderingColumnName ->
rawRows.stream().sorted((row1, row2) -> {
Review comment:
> It seems that there is no code change. What is the purpose of format
change?
I'm used to changing it by the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
