n3nash commented on a change in pull request #1307: [HUDI-570] - Improve test 
coverage for FSUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1307#discussion_r375039117
 
 

 ##########
 File path: 
hudi-common/src/test/java/org/apache/hudi/common/util/TestFSUtils.java
 ##########
 @@ -261,4 +289,87 @@ public void testLogFilesComparison() {
   public static String makeOldLogFileName(String fileId, String 
logFileExtension, String baseCommitTime, int version) {
     return "." + String.format("%s_%s%s.%d", fileId, baseCommitTime, 
logFileExtension, version);
   }
+
+  private void cleanupFiles(File[] cleanupFiles) {
 
 Review comment:
   Once you use the basePath from the DFS started by the TestHarness and create 
files underneath, when the test dies, it will automatically clean those files. 
You shouldn't need to clean it here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to