n3nash commented on a change in pull request #1242: [HUDI-544] Adjust the read
and write path of archive
URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r375039736
##########
File path:
hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java
##########
@@ -138,9 +139,11 @@ public String showCommits(
throws IOException {
System.out.println("===============> Showing only " + limit + " archived
commits <===============");
- String basePath = HoodieCLI.getTableMetaClient().getBasePath();
+ HoodieTableMetaClient metaClient = HoodieCLI.getTableMetaClient();
+ String basePath = metaClient.getBasePath();
+ Path archivePath = new Path(metaClient.getArchivePath() +
"/.commits_.archive*");
FileStatus[] fsStatuses =
- FSUtils.getFs(basePath, HoodieCLI.conf).globStatus(new Path(basePath +
"/.hoodie/.commits_.archive*"));
+ FSUtils.getFs(basePath, HoodieCLI.conf).globStatus(archivePath);
Review comment:
archivePath = new Path(metaClient.getArchivePath() + "/.commits_.archive*")
is equivalent of new Path(basePath + "/.hoodie/.commits_.archive*"). the
metaClient.getArchivePath() should return `basePath + "/.hoodie"` for all old
tables.
@hmatu what concerns do you have ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
