yihua opened a new pull request #4875:
URL: https://github.com/apache/hudi/pull/4875
## What is the purpose of the pull request
This PR fixes the problem of incorrect value and null count read from column
stats in metadata table. The root cause is the wrong order of arguments passed
to the constructor of `HoodieMetadataColumnStats`. The constructor is:
```
public HoodieMetadataColumnStats(java.lang.String fileName,
java.lang.String minValue, java.lang.String maxValue, java.lang.Long
valueCount, java.lang.Long nullCount, java.lang.Long totalSize, java.lang.Long
totalUncompressedSize, java.lang.Boolean isDeleted) {
```
and the original init is
```
columnStatMetadata = new HoodieMetadataColumnStats(
(String) v.get(COLUMN_STATS_FIELD_RESOURCE_NAME),
(String) v.get(COLUMN_STATS_FIELD_MIN_VALUE),
(String) v.get(COLUMN_STATS_FIELD_MAX_VALUE),
(Long) v.get(COLUMN_STATS_FIELD_NULL_COUNT),
(Long) v.get(COLUMN_STATS_FIELD_VALUE_COUNT),
(Long) v.get(COLUMN_STATS_FIELD_TOTAL_SIZE),
(Long) v.get(COLUMN_STATS_FIELD_TOTAL_UNCOMPRESSED_SIZE),
(Boolean) v.get(COLUMN_STATS_FIELD_IS_DELETED)
);
```
The actual values of `valueCount` and `nullCount` passed in are switched.
(Below screenshot shows the diff of column stats from validation: left: from
metadata table, right: from base files (ground truth))
<img width="1906" alt="Screen Shot 2022-02-22 at 16 07 32"
src="https://user-images.githubusercontent.com/2497195/155242751-8c12e336-9ab7-42e6-beb9-d9913c8a14a3.png";>
## Brief change log
- Uses builder of `HoodieMetadataColumnStats` in `HoodieMetadataPayload`
to set each field explicitly.
## Verify this pull request
Runs Hudi Deltastreamer continuous mode writing MOR table, async compaction,
cleaner, all multi-modal indexing enabled and verifies that the column stats
from metadata table is correct compared to the ground truth from base files.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/2497195/155242751-8c12e336-9ab7-42e6-beb9-d9913c8a14a3.png"](https://user-images.githubusercontent.com/2497195/155242751-8c12e336-9ab7-42e6-beb9-d9913c8a14a3.png"){kind=link}