nsivabalan commented on a change in pull request #4860:
URL: https://github.com/apache/hudi/pull/4860#discussion_r813154754
##########
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeUnmergedRecordReader.java
##########
@@ -74,7 +78,7 @@ public RealtimeUnmergedRecordReader(RealtimeSplit split,
JobConf job,
this.parquetRecordsIterator = new
RecordReaderValueIterator<>(this.parquetReader);
this.executor = new BoundedInMemoryExecutor<>(
HoodieRealtimeRecordReaderUtils.getMaxCompactionMemoryInBytes(jobConf),
getParallelProducers(),
- Option.empty(), x -> x, new DefaultSizeEstimator<>());
+ Option.empty(), Function.identity(), new DefaultSizeEstimator<>(),
Functions.noop());
Review comment:
we already have a overloaded constructor which sets Functions.noop() as
last arg. we don't need to set explicitly here.
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/queue/BoundedInMemoryExecutor.java
##########
@@ -54,29 +56,35 @@
private final List<BoundedInMemoryQueueProducer<I>> producers;
// Consumer
private final Option<BoundedInMemoryQueueConsumer<O, E>> consumer;
+ // pre-execute function to implement environment specific behavior before
executors (producers/consumer) run
+ private final Runnable preExecute;
Review comment:
nit: may be we can name this preExecuteRunnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
