danny0405 commented on a change in pull request #4880:
URL: https://github.com/apache/hudi/pull/4880#discussion_r812620201
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -475,12 +475,12 @@ private void writeToBuffer(HoodieRecord<T> record) {
}
Option<IndexedRecord> indexedRecord = getIndexedRecord(record);
if (indexedRecord.isPresent()) {
- // Skip the Ignore Record.
+ // Skip the ignored record.
if (!indexedRecord.get().equals(IGNORE_RECORD)) {
recordList.add(indexedRecord.get());
}
} else {
- keysToDelete.add(record.getKey());
+ keysToDelete.add(DeleteKey.create(record.getKey(),
record.getData().getOrderingVal()));
}
Review comment:
Hello, @vinothchandar , can you take a look if you have time ? The only
concern is that the new encoding/decoding breaks the compatibility. I have no
good idea how to be compatible yet.
But i want to address that before the patch, the handle may cause data lost.
Comparing to compatibility, correctness is more important i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
