yihua commented on a change in pull request #4866:
URL: https://github.com/apache/hudi/pull/4866#discussion_r814430697
##########
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java
##########
@@ -140,35 +142,64 @@
public static final TypeDescription ORC_TRIP_SCHEMA =
AvroOrcUtils.createOrcSchema(new Schema.Parser().parse(TRIP_SCHEMA));
public static final Schema FLATTENED_AVRO_SCHEMA = new
Schema.Parser().parse(TRIP_FLATTENED_SCHEMA);
- private static final Random RAND = new Random(46474747);
+ private final Random r;
Review comment:
I actually tried to search the variable and see if anything is missed.
`r` gives me hard time :) Besides, I usually use `rand` and try to avoid single
character variable. More like a style thing, not strong opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
