yihua commented on a change in pull request #4847:
URL: https://github.com/apache/hudi/pull/4847#discussion_r814479652



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java
##########
@@ -200,4 +215,65 @@ protected boolean isWorkloadProfileNeeded() {
 
   protected abstract Iterator<List<WriteStatus>> handleUpdate(String 
partitionPath, String fileId,
       Iterator<HoodieRecord<T>> recordItr) throws IOException;
+
+  protected HoodieWriteMetadata<HoodieData<WriteStatus>> 
executeClustering(HoodieClusteringPlan clusteringPlan) {
+    HoodieInstant instant = 
HoodieTimeline.getReplaceCommitRequestedInstant(instantTime);

Review comment:
       I think the goal is to revamp the commit executors and write pipeline 
altogether later on, so the refactoring here is limited to code reuse.  
@xushiyan is that the case?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to