vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some
guidance about how to judge the scope of MINOR to the contribution guidance
URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375999410
##########
File path: docs/_pages/contributing.cn.md
##########
@@ -88,7 +88,11 @@ and more importantly also try to improve the process along
the way as well.
- Once you finalize on a project/task, please open a new JIRA or assign an
existing one to yourself.
- Almost all PRs should be linked to a JIRA. It's always good to have a
JIRA upfront to avoid duplicating efforts.
- - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA.
+ - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA. Below are some tips to judge **MINOR** Pull
Request :
+ - trivial fixes (for example, a typo, a broken link, intellisense or
an obvious error)
+ - the change is not functionality relevant
Review comment:
nit: the change does not alter functionality or performance in any way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
