This is an automated email from the ASF dual-hosted git repository.
vinoyang pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git
The following commit(s) were added to refs/heads/asf-site by this push:
new b1bb7b0 [HUDI-602] Add some guidance about how to judge the scope of
MINOR to the contribution guidance (#1311)
b1bb7b0 is described below
commit b1bb7b0e050b2d7acfb7c5bccdbc2a98e6a35743
Author: vinoyang <[email protected]>
AuthorDate: Fri Feb 7 15:00:43 2020 +0800
[HUDI-602] Add some guidance about how to judge the scope of MINOR to the
contribution guidance (#1311)
* [HUDI-602] Add some guidance about how to judge the scope of MINOR to the
contribution guidance
---
docs/_pages/contributing.cn.md | 6 +++++-
docs/_pages/contributing.md | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/docs/_pages/contributing.cn.md b/docs/_pages/contributing.cn.md
index 9e017ad..e66deea 100644
--- a/docs/_pages/contributing.cn.md
+++ b/docs/_pages/contributing.cn.md
@@ -88,7 +88,11 @@ and more importantly also try to improve the process along
the way as well.
- Once you finalize on a project/task, please open a new JIRA or assign an
existing one to yourself.
- Almost all PRs should be linked to a JIRA. It's always good to have a
JIRA upfront to avoid duplicating efforts.
- - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA.
+ - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA. Below are some tips to judge **MINOR** Pull
Request :
+ - trivial fixes (for example, a typo, a broken link, intellisense or
an obvious error)
+ - the change does not alter functionality or performance in any way
+ - changed lines less than 100
+ - obviously judge that the PR would pass without waiting for CI / CD
verification
- But, you may be asked to file a JIRA, if reviewer deems it necessary
- Before you begin work,
- Claim the JIRA using the process above and assign the JIRA to yourself.
diff --git a/docs/_pages/contributing.md b/docs/_pages/contributing.md
index 3745edd..9d84872 100644
--- a/docs/_pages/contributing.md
+++ b/docs/_pages/contributing.md
@@ -87,7 +87,11 @@ and more importantly also try to improve the process along
the way as well.
- Once you finalize on a project/task, please open a new JIRA or assign an
existing one to yourself.
- Almost all PRs should be linked to a JIRA. It's always good to have a
JIRA upfront to avoid duplicating efforts.
- - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA.
+ - If the changes are minor, then `[MINOR]` prefix can be added to Pull
Request title without a JIRA. Below are some tips to judge **MINOR** Pull
Request :
+ - trivial fixes (for example, a typo, a broken link, intellisense or
an obvious error)
+ - the change does not alter functionality or performance in any way
+ - changed lines less than 100
+ - obviously judge that the PR would pass without waiting for CI / CD
verification
- But, you may be asked to file a JIRA, if reviewer deems it necessary
- Before you begin work,
- Claim the JIRA using the process above and assign the JIRA to yourself.
