danny0405 commented on pull request #4880: URL: https://github.com/apache/hudi/pull/4880#issuecomment-1053032393
> I skimmed through the patch. Looks like, we are looking to fix only a specific scenario. > > insert record with preCombine value 100. delete record with preCombine value 50. > > So, as per master, the record will be deleted. and with this patch, we will not delete the record and honor the insert as valid record. > > let me know if my understanding is right. And whats the plan for other scenarios which I have called out earlier. Yes, your understanding is correct. > So, are we proposing to retain all deleted records forever in this patch or are we fixing only the case where we maintain the strict ordering only until compaction kicks in. It not only fixes the compaction but also the MOR reader, with this path, we would have same event time ordering semantics for both COW table and MOR table. Say, we should always obey the event time ordering of the messages and keep consistent query result no matter what the input sequence is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
