codope commented on a change in pull request #4848:
URL: https://github.com/apache/hudi/pull/4848#discussion_r815594374
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieDeltaWriteStat.java
##########
@@ -69,4 +73,24 @@ public void addLogFiles(String logFile) {
public List<String> getLogFiles() {
return logFiles;
}
+
+ public void setRecordsStats(RecordsStats<? extends Map> stats) {
+ recordsStats = Option.of(stats);
+ }
+
+ public Option<RecordsStats<? extends Map>> getRecordsStats() {
+ return recordsStats;
+ }
+
+ public static class RecordsStats<T> implements Serializable {
Review comment:
Wrapper abstracts away the underlying metadata. I think write stat
should be aware that it saves the record stats but not necessarily what those
stats are composed of. Are you concerned about serde cost here? It shouldn't
add much overhead over keeping it as a prvate field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
