YuweiXiao commented on a change in pull request #4480:
URL: https://github.com/apache/hudi/pull/4480#discussion_r816410118
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/HoodieBucketIndex.java
##########
@@ -37,28 +36,30 @@
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
-import java.util.HashMap;
-import java.util.Map;
+import java.util.List;
/**
* Hash indexing mechanism.
*/
-public class HoodieBucketIndex extends HoodieIndex<Object, Object> {
+public abstract class HoodieBucketIndex extends HoodieIndex<Object, Object> {
- private static final Logger LOG =
LogManager.getLogger(HoodieBucketIndex.class);
+ private static final Logger LOG =
LogManager.getLogger(HoodieBucketIndex.class);
- private final int numBuckets;
+ protected int numBuckets;
+ protected String indexKeyFields;
public HoodieBucketIndex(HoodieWriteConfig config) {
super(config);
- numBuckets = config.getBucketIndexNumBuckets();
- LOG.info("use bucket index, numBuckets=" + numBuckets);
+
+ this.numBuckets = config.getBucketIndexNumBuckets();
+ this.indexKeyFields = config.getBucketIndexHashField();
+ LOG.info("use bucket index, numBuckets = " + numBuckets + ", indexFields:
" + indexKeyFields);
Review comment:
Will check all logs to make them consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
