danny0405 commented on a change in pull request #4911:
URL: https://github.com/apache/hudi/pull/4911#discussion_r817309658



##########
File path: 
hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -459,6 +461,18 @@ private FlinkOptions() {
   //  Compaction Options
   // ------------------------------------------------------------------------
 
+  public static final ConfigOption<Double> COMPACTION_MEMORY_FRACTION_PROP = 
ConfigOptions
+      .key(HoodieRealtimeConfig.COMPACTION_MEMORY_FRACTION_PROP)
+      .doubleType()
+      .defaultValue(0.1)
+      .withDescription("Fraction of Flink TM memory used for compaction of log 
files.");
+
+  public static final ConfigOption<MemorySize> COMPACTION_MEMORY_SIZE = 
ConfigOptions
+          .key("compaction.memory.size")
+          .memoryType()
+          .noDefaultValue()
+          .withDescription("Specify the memory of Flink TM used for compaction 
of log files.");

Review comment:
       Need to sync these options to `FlinkStreamerConfig` and 
`FlinkCompactionConfig`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to