n3nash commented on a change in pull request #1320: [HUDI-571] Add min/max
headers on archived files
URL: https://github.com/apache/incubator-hudi/pull/1320#discussion_r378425612
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieArchivedTimeline.java
##########
@@ -182,8 +183,11 @@ private String getMetadataKey(String action) {
//read the avro blocks
while (reader.hasNext()) {
HoodieAvroDataBlock blk = (HoodieAvroDataBlock) reader.next();
- // TODO If we can store additional metadata in datablock, we can
skip parsing records
- // (such as startTime, endTime of records in the block)
+ if (isDataOutOfRange(blk, filter)) {
Review comment:
We only know that the data is out of range from the block and not from the
whole file right ? So, this should be continue instead of break ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
