XuQianJin-Stars commented on a change in pull request #4720: URL: https://github.com/apache/hudi/pull/4720#discussion_r819186894
########## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestTimeTravelParser.scala ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.hudi + +import org.apache.hudi.HoodieSparkUtils +import org.apache.spark.sql.catalyst.TableIdentifier +import org.apache.spark.sql.catalyst.analysis.{UnresolvedRelation, UnresolvedStar} +import org.apache.spark.sql.catalyst.expressions.Literal +import org.apache.spark.sql.catalyst.plans.logical.{Project, TimeTravelRelation} + +class TestTimeTravelParser extends TestHoodieSqlBase { + private val parser = spark.sessionState.sqlParser + + test("time travel of timestamp") { + if (HoodieSparkUtils.isSpark3_2) { + val timeTravelPlan1 = parser.parsePlan("SELECT * FROM A.B " + + "TIMESTAMP AS OF '2019-01-29 00:37:58'") + + assertResult(Project(Seq(UnresolvedStar(None)), + TimeTravelRelation( + UnresolvedRelation(new TableIdentifier("B", Option.apply("A"))), + Some(Literal("2019-01-29 00:37:58")), + None))) { + timeTravelPlan1 + } + + val timeTravelPlan2 = parser.parsePlan("SELECT * FROM A.B " + + "TIMESTAMP AS OF 1643119574") + + assertResult(Project(Seq(UnresolvedStar(None)), + TimeTravelRelation( + UnresolvedRelation(new TableIdentifier("B", Option.apply("A"))), + Some(Literal(1643119574)), + None))) { + timeTravelPlan2 + } + } + } + + test("time travel of version") { + if (HoodieSparkUtils.isSpark3_2) { + val timeTravelPlan1 = parser.parsePlan("SELECT * FROM A.B " + + "VERSION AS OF 'Snapshot123456789'") Review comment: I think there is no need to throw an exception when parsing. It's just fine to handle it in `HoodieAnalysis#timetravelrelation`. This syntax is also supported in spark 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
