xushiyan commented on a change in pull request #4720:
URL: https://github.com/apache/hudi/pull/4720#discussion_r820245283
##########
File path: hudi-spark-datasource/hudi-spark3/pom.xml
##########
@@ -157,7 +175,7 @@
<dependency>
<groupId>org.apache.spark</groupId>
<artifactId>spark-sql_2.12</artifactId>
- <version>${spark3.version}</version>
+ <version>${spark3.2.version}</version>
Review comment:
we should prefer to simple set of properties to maintain: both
`spark3.version` and `hudi.spark.module` change based on different spark
profile. When `spark3.version` switch to `3.1.2`, module will be
`hudi-spark3.1.x` and effectively ignores `hudi-spark3` here. So I don't think
we need to introduce more properties here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
