pratyakshsharma commented on a change in pull request #4944:
URL: https://github.com/apache/hudi/pull/4944#discussion_r820262671
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java
##########
@@ -98,9 +98,15 @@ public HiveSyncTool(HiveSyncConfig cfg, HiveConf
configuration, FileSystem fs) {
this.roTableName = Option.empty();
break;
case MERGE_ON_READ:
- this.snapshotTableName = cfg.tableName + SUFFIX_SNAPSHOT_TABLE;
- this.roTableName = cfg.skipROSuffix ? Option.of(cfg.tableName) :
- Option.of(cfg.tableName + SUFFIX_READ_OPTIMIZED_TABLE);
+ if (cfg.customMorTableName &&
!StringUtils.isNullOrEmpty(cfg.customRTTableName)
+ && !StringUtils.isNullOrEmpty(cfg.customROTableName) &&
!cfg.customRTTableName.equals(cfg.customROTableName)) {
Review comment:
better to have .equalsIgnoreCase() here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
