codope commented on a change in pull request #4848:
URL: https://github.com/apache/hudi/pull/4848#discussion_r820837051



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
##########
@@ -922,4 +952,39 @@ public static int getPartitionFileGroupCount(final 
MetadataPartitionType partiti
     }
   }
 
+  /**
+   * Computes column range metadata
+   *
+   * @param recordList                        - list of records from which 
column range statistics will be computed
+   * @param field                             - column name for which 
statistics will be computed
+   * @param filePath                          - data file path
+   * @param columnRangeMap                    - old column range statistics, 
which will be merged in this computation
+   * @param consistentLogicalTimestampEnabled - flag to deal with logical 
timestamp type when getting column value
+   */
+  public static void accumulateColumnRanges(List<IndexedRecord> recordList, 
Schema.Field field, String filePath,

Review comment:
       Good point. I have changed accrodingly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to