umehrot2 commented on a change in pull request #1330: [HUDI-607] Fix to allow 
creation/syncing of Hive tables partitioned by Date type columns
URL: https://github.com/apache/incubator-hudi/pull/1330#discussion_r380346318
 
 

 ##########
 File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java
 ##########
 @@ -77,6 +80,11 @@ public static Object getNestedFieldVal(GenericRecord 
record, String fieldName, b
 
       // return, if last part of name
       if (i == parts.length - 1) {
+
+        if (isLogicalTypeDate(valueNode, part)) {
+          return LocalDate.ofEpochDay(Long.parseLong(val.toString()));
 
 Review comment:
   From my understanding, I don't think Spark's `DateType` has a timezone. It 
should be using the Local TimeZone. Same goes for `LocalDate`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to