codope opened a new pull request #5013:
URL: https://github.com/apache/hudi/pull/5013
## What is the purpose of the pull request
`TypedProperties#keys` is not thread-safe. It was added in #4712 to ensure
insertion order of properties is maintained. It was done in order to add a
table checksum config in the end which would be used to validate that
`hoodie.properties` is not written partially. However, TypedProperties not
being thread-safe could result in ConcurrentModificationException as there are
places in clustering where write config is passed to spark executor and it
might happen that while one thread is trying to serialize it the other is
trying to modify it. However, the solution to original problem need not depend
on ordering. We can just add table checksum in the end and then while reading
`hoodie.properties` just ensure that prop exists.
## Brief change log
- Remove `TypedProperties#keys`
- Convert props to linked hashmap and then add table checksum config and
then flush it to `hoodie.properties`.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test
coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please
describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under
an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
