nsivabalan commented on a change in pull request #4971:
URL: https://github.com/apache/hudi/pull/4971#discussion_r823970238
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
##########
@@ -519,14 +521,19 @@ public abstract HoodieRestoreMetadata
restore(HoodieEngineContext context,
String restoreInstantTime,
String instantToRestore);
+ public void rollbackInflightCompaction(HoodieInstant inflightInstant) {
+ rollbackInflightCompaction(inflightInstant, s -> Option.empty());
+ }
+
/**
* Rollback failed compactions. Inflight rollbacks for compactions revert
the .inflight file
* to the .requested file.
*
* @param inflightInstant Inflight Compaction Instant
*/
- public void rollbackInflightCompaction(HoodieInstant inflightInstant) {
- String commitTime = HoodieActiveTimeline.createNewInstantTime();
+ public void rollbackInflightCompaction(HoodieInstant inflightInstant,
Function<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInstantFunc) {
Review comment:
this method is in HoodieTable and not in Writeclient layer. and hence
had to do it this way since getPendingRollbackInstantFunc is present in
writeClient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
