alexeykudinkin commented on a change in pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#discussion_r825124810
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkMergeHelper.java
##########
@@ -77,7 +77,7 @@ public void runMerge(HoodieTable<T, JavaRDD<HoodieRecord<T>>,
JavaRDD<HoodieKey>
readSchema = mergeHandle.getWriterSchemaWithMetaFields();
}
- BoundedInMemoryExecutor<GenericRecord, GenericRecord, Void> wrapper = null;
+ BoundedInMemoryExecutor<GenericRecord, GenericRecord, Void> executor =
null;
Review comment:
@vinothchandar i actually asked to do it, while @guanziyue was fixing
things here.
We talked about it, and surely I see your point that this expands the
surface for reviewer, but am afraid that small clean ups like that if not done
right away, they're just sentenced to not be done ever (since someone will need
to consciously set time to come back and clean this up)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
