vinothchandar commented on a change in pull request #5004:
URL: https://github.com/apache/hudi/pull/5004#discussion_r827504986
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieHFileConfig.java
##########
@@ -42,12 +42,12 @@
private final boolean dropBehindCacheCompaction;
private final Configuration hadoopConf;
private final BloomFilter bloomFilter;
- private final KeyValue.KVComparator hfileComparator;
+ private final CellComparator hfileComparator;
Review comment:
Per discussion. there is a potential issue of 0.11 queries not being
able to read 0.9 tables, because the
`org.apache.hadoop.hbase.KeyValue.KVComparator` class is written into HFile 1.x
(0.9 table) and since we now shade hbase in 0.11 as
`org.apache.hudi.org.apache.hadoop.hbase.KeyValue.KVComparator`.
If we ship the `KVComparator` class along with our jar, then we will be
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
