xushiyan commented on a change in pull request #4175:
URL: https://github.com/apache/hudi/pull/4175#discussion_r824616293
##########
File path:
hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/AbstractSyncTool.java
##########
@@ -17,17 +17,31 @@
package org.apache.hudi.sync.common;
+import org.apache.hudi.common.config.TypedProperties;
+
+import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.FileSystem;
import java.util.Properties;
+/**
+ * Base class to sync Hudi meta data with Metastores to make
+ * Hudi table queryable through external systems.
+ */
public abstract class AbstractSyncTool {
- protected Properties props;
- protected FileSystem fileSystem;
+ protected final Configuration conf;
+ protected final FileSystem fs;
+ protected TypedProperties props;
- public AbstractSyncTool(Properties props, FileSystem fileSystem) {
+ public AbstractSyncTool(TypedProperties props, Configuration conf,
FileSystem fs) {
this.props = props;
- this.fileSystem = fileSystem;
+ this.conf = conf;
+ this.fs = fs;
+ }
+
+ @Deprecated
Review comment:
```suggestion
/**
* @deprecated <some notes>
*/
@Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
