codope commented on a change in pull request #5070:
URL: https://github.com/apache/hudi/pull/5070#discussion_r830555950
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
##########
@@ -461,11 +461,9 @@ public String getPreCombineField() {
}
public Option<String[]> getRecordKeyFields() {
- if (contains(RECORDKEY_FIELDS)) {
- return Option.of(Arrays.stream(getString(RECORDKEY_FIELDS).split(","))
- .filter(p -> p.length() >
0).collect(Collectors.toList()).toArray(new String[] {}));
- }
- return Option.empty();
Review comment:
Should we localize this change? With your change, this method will no
longer return Option.empty()? Is there any caller dependent on this behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
