danny0405 commented on a change in pull request #5018:
URL: https://github.com/apache/hudi/pull/5018#discussion_r830810428
##########
File path:
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/FlinkWriteHelper.java
##########
@@ -113,5 +114,10 @@ public static FlinkWriteHelper newInstance() {
hoodieRecord.setCurrentLocation(rec1.getCurrentLocation());
return hoodieRecord;
}).orElse(null)).filter(Objects::nonNull).collect(Collectors.toList());
+
+ if (hasInsert) {
+ recordList.get(0).getCurrentLocation().setInstantTime("I");
+ }
+ return recordList;
Review comment:
Yes, the Map::values does not guarantee the sequence, state index based
writer has no problem because it assigns the instant "I" and "U" based on the
buckets of last checkpoint, and reuse the buckets within one checkpoint.
This fix is necessary for it to be more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
