sekaiga commented on a change in pull request #5052:
URL: https://github.com/apache/hudi/pull/5052#discussion_r830840093
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
##########
@@ -217,16 +215,21 @@ public synchronized void scan(Option<List<String>> keys) {
&&
!HoodieTimeline.compareTimestamps(logBlock.getLogBlockHeader().get(INSTANT_TIME),
HoodieTimeline.LESSER_THAN_OR_EQUALS, this.latestInstantTime
)) {
// hit a block with instant time greater than should be processed,
stop processing further
+ LOG.info("hit a block with instant time greater than should be
processed, stop processing further. logfile: + " + logFile
+ + " , blockType: " + logBlock.getBlockType() + " ,
instantTime: " + instantTime + " , latestInstantTime : " + latestInstantTime );
break;
}
if (logBlock.getBlockType() != CORRUPT_BLOCK &&
logBlock.getBlockType() != COMMAND_BLOCK) {
- if
(!completedInstantsTimeline.containsOrBeforeTimelineStarts(instantTime)
- || inflightInstantsTimeline.containsInstant(instantTime)) {
+ if (!checkIfValidCommit(instantTime) ||
inflightInstantsTimeline.containsInstant(instantTime)) {
Review comment:
im explained in jira ：https://issues.apache.org/jira/browse/HUDI-3644
when log file block append sucess. And deltacommit rollback. And this
instance time is not before activeTimeline starts. This log file block will be
merged, cause data duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
