vinothchandar commented on a change in pull request #4406:
URL: https://github.com/apache/hudi/pull/4406#discussion_r831011643
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1834,10 +1836,24 @@ public WriteConcurrencyMode getWriteConcurrencyMode() {
return WriteConcurrencyMode.fromValue(getString(WRITE_CONCURRENCY_MODE));
}
- public Boolean inlineTableServices() {
+ /**
+ * Are any table services configured to run inline?
+ *
+ * @return True if any table services are configured to run inline, false
otherwise.
+ */
+ public Boolean areAnyTableServicesInline() {
Review comment:
should this check for asyncClean instead of just `isAutoClean()`
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##########
@@ -1834,10 +1836,24 @@ public WriteConcurrencyMode getWriteConcurrencyMode() {
return WriteConcurrencyMode.fromValue(getString(WRITE_CONCURRENCY_MODE));
}
- public Boolean inlineTableServices() {
+ /**
+ * Are any table services configured to run inline?
+ *
+ * @return True if any table services are configured to run inline, false
otherwise.
+ */
+ public Boolean areAnyTableServicesInline() {
return inlineClusteringEnabled() || inlineCompactionEnabled() ||
isAutoClean();
}
+ /**
+ * Are any table services configured to run async?
Review comment:
technically speaking, both can return false, if compaction is inline and
say cleaning is async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
