nsivabalan commented on pull request #4507: URL: https://github.com/apache/hudi/pull/4507#issuecomment-1073866571
If we perform a savepoint from the CLI, while there are inflight writes or pending table services? A: Do you mean "savepoint" or "restore" in above question? If its "savepoint", savepoint can be done only on completed commit. so should not matter if there are any new write in flight. if you meant "restore", as we know, restore is a destructive operation and users are advised to stop all pipelines before they trigger restore. or can expect all queries to fail when they trigger restore. In line 92, we only work with the base file view? how would this correctly restore the log data? A: yes, even I was surprised. Its mainly because of the way our cleaning and rollback works. Both works at file slice level. i..e cleaner will clean up only entire file slice(if entire file slice is eligible to be cleaned up). and rollback will remove/delete data and log files only if entire file slice is expected to be rolledback. If not, rollback will just do a append of log blocks. And so, we don't need to do any special handling for log files in general wrt savepoint and restore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
