yihua commented on a change in pull request #4962:
URL: https://github.com/apache/hudi/pull/4962#discussion_r832578536
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -137,4 +157,27 @@
throw new HoodieIOException("Unable to read metadata for instant " +
hoodieInstantOption.get(), io);
}
}
-}
\ No newline at end of file
+
+ /**
+ * Get pending instant.
+ *
+ * @param metaClient
+ * @return
+ */
+ public static Set<String> getPendingRequestedInstants(HoodieTableMetaClient
metaClient) {
Review comment:
nit: rename to `getInflightInstants`
##########
File path:
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestSimpleConcurrentFileWritesConflictResolutionStrategy.java
##########
@@ -318,16 +321,20 @@ private void createCommit(String instantTime) throws
Exception {
.withBaseFilesInPartition(HoodieTestDataGenerator.DEFAULT_FIRST_PARTITION_PATH,
fileId1, fileId2);
}
- private HoodieCommitMetadata createCommitMetadata(String instantTime) {
+ private HoodieCommitMetadata createCommitMetadata(String instantTime, String
writFileName) {
Review comment:
nit: `writFileName` -> `writeFileName`
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/utils/TransactionUtils.java
##########
@@ -105,6 +115,16 @@
return thisCommitMetadata;
}
+ public static Option<HoodieCommitMetadata> resolveWriteConflictIfAny(
Review comment:
I think this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
