bvaradar commented on a change in pull request #1345: [HUDI-618] Adding unit 
tests for PriorityBasedFileSystemView
URL: https://github.com/apache/incubator-hudi/pull/1345#discussion_r384694490
 
 

 ##########
 File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java
 ##########
 @@ -207,20 +207,18 @@ public RemoteHoodieTableFileSystemView(String server, 
int port, HoodieTableMetaC
   @Override
   public Stream<HoodieBaseFile> getLatestBaseFiles(String partitionPath) {
     Map<String, String> paramsMap = getParamsWithPartitionPath(partitionPath);
-    try {
-      List<BaseFileDTO> dataFiles = 
executeRequest(LATEST_PARTITION_DATA_FILES_URL, paramsMap,
-          new TypeReference<List<BaseFileDTO>>() {}, RequestMethod.GET);
-      return dataFiles.stream().map(BaseFileDTO::toHoodieBaseFile);
-    } catch (IOException e) {
-      throw new HoodieRemoteException(e);
-    }
+    return getLatestBaseFilesFromParams(paramsMap, 
LATEST_PARTITION_DATA_FILES_URL);
   }
 
   @Override
   public Stream<HoodieBaseFile> getLatestBaseFiles() {
     Map<String, String> paramsMap = getParams();
+    return getLatestBaseFilesFromParams(paramsMap, LATEST_ALL_DATA_FILES);
 
 Review comment:
   Thanks for the cleanup. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to